Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Role change for Lead #562

Merged
merged 2 commits into from
Oct 4, 2022
Merged

REQUEST: Role change for Lead #562

merged 2 commits into from
Oct 4, 2022

Conversation

joaopapereira
Copy link
Member

@joaopapereira joaopapereira commented Sep 20, 2022

Summary

This is a formal request for consideration of a role change in the Carvel project by a member of the community.

Each role is defined in our contribution model document. If you would like to request mutliple roles / multiple
subprojects,
please open a new issue for each request.

GitHub Username

@joaopapereira

Role Requested

  • Reviewer
  • Approver
  • Lead

Applicable Subproject

General Requirements

Role Specific Requirements

[LINK_TO_REVIEWER_DEFINITION] Reviewer

  • I have reviewed / authored of at least 5 substantial* pull requests to the subproject(s).

[LINK_TO_APPROVER_DEFINITION] Approver

  • I have reviewed / authored several substantial* pull requests to the codebase.
  • Demonstrated the ability to plan and execute a track of work.

[LINK_TO_LEAD_DEFINITION] Approver

  • I have a deep understanding of the technical goals and direction of the subproject.
  • I have a deep understanding of the domains of the subproject.
  • I have a deep understanding of the design of the subproject.
  • I have contributed to the design and direction by doing all of:
    • Authoring and reviewing proposals.
    • Initiating, contributing and resolving discussions (emails, GitHub issues, meetings).
    • Identifying subtle or complex issues in designs and implementation PRs.
    • Directly contributed to the subproject through implementation and / or review.

Sponsors

List of contributions to the Carvel subprojects(s)

I have been an active contributor to imgpkg for the past year and a half and served as an approver for more than a
year.
During this time I was responsible for developing, roadmap, triaging, and giving support for imgpkg

PRs reviewed / authored

Currently, I authored a total of 74 PRs in the project and reviewed/approved the majority of the other PRs.
Some of the most relevant PRs are:

Issues responded to

When responding to issues I try to be proactive and better understand the problem the user is facing as well as think
about a solution and validate it with the requester.
Some examples of this are:

Projects I am involved with

The first project I was part of when I joined was to do a major refactor of imgpkg to better organize the code. After that
I was part of almost all the big projects of imgpkg.
Some examples of these projects are:

Apart from the above-mentioned, you can find me in our Slack channel helping our users with questions about imgpkg and
other tools.

Vision for the tool

I see imgpkg as tool that can help standardize how software is grouped and transported from the creators to the users in a secure and timely manner.
To accomplish this I believe that we need to ensure the support for other tools to easily check bundles for CVEs, and validate the origin of the bundles.
Another area where I would like to see imgpkg grow is in its support for other projects to consume it as a library. I believe that this could unlock a wider adoption of the awesome bundle format. There are some examples, in the wild, of people interacting with imgpkg via a call to the binary, but I believe that if we provide a reacher API it would make this integration more appealing and much richer.

In terms of research, I would love to better understand how might imgpkg and the bundle format be used by other projects, like helm, to create a better experience for them.

In general, I believe, that imgpkg is positioned itself as a better way to help software creators package their software and we should try to double down on this moving forward. Some of the prior ideas are examples of how might we accomplish this.

Next Steps

  • Once your sponsors have responded with a +1 for your nomination, your request will be reviewed by the project leads.
    Any missing information will be requested.

- Add Joao as a Lead for `imgpkg`

Signed-off-by: Joao Pereira <[email protected]>
@pivotaljohn
Copy link
Contributor

My name is @pivotaljohn and I approve this message. 😉

Seriously, tho... Joao demonstrates:

  • sharp design sense through his well reasoned (and succinctly articulated) conversations (in the PRs referenced, but elsewhere as well).
  • commitment to see big ideas from start through finish, given his multiple meaty (feature group sized) contributions to imgpkg ... contributions that have made this tool what it is.
  • cohesive vision that extends the Carvel Intent: to make our software deeply composable, affording users the ability to integrate in the way that best works for them. He also has compelling next targets for research.

Copy link
Contributor

@joe-kimmel-vmw joe-kimmel-vmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what's already said.

@cppforlife
Copy link
Contributor

and for me as the last approver on this PR...

im +1 on @joaopapereira becoming a lead for imgpkg. he has demonstrated deep knowledge and vision in this domain.

@aaronshurley aaronshurley merged commit b08b75d into develop Oct 4, 2022
@aaronshurley aaronshurley deleted the proposal-imgpkg-lead branch October 4, 2022 20:03
@aaronshurley
Copy link
Contributor

Merged based on previous approvals. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants