-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated describe command to show layer's digest of each image #622
Conversation
Signed-off-by: kumari tanushree <[email protected]>
4bbc8be
to
9790a03
Compare
Signed-off-by: kumari tanushree <[email protected]>
9790a03
to
8eee075
Compare
13ecdfd
to
42fd005
Compare
42fd005
to
18f36fb
Compare
18f36fb
to
15dc5d0
Compare
15dc5d0
to
f25d8e5
Compare
5121899
to
bd8f085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the one small nit, looks good to me.
bd8f085
to
8301a60
Compare
Signed-off-by: kumari tanushree <[email protected]>
8301a60
to
50da503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After you do the change I proposed in the PR, if all test pass you can merge the PR
test/helpers/image_factory.go
Outdated
@@ -42,6 +42,25 @@ func (i *ImageFactory) ImageDigest(imgRef string) string { | |||
return digest.String() | |||
} | |||
|
|||
// GetImageLayerDigest will return image's layer digest | |||
func (i *ImageFactory) GetImageLayerDigest(image string) []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func (i *ImageFactory) GetImageLayerDigest(image string) []string { | |
func (i *ImageFactory) GetFirstLayerDigest(image string) []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are returning all layers hence will rename it to GetImageLayersDigest
. Also image which is used in e2e test has single layers so should work with reading first element of the returned array.
7017072
to
a01de62
Compare
Signed-off-by: kumari tanushree <[email protected]>
a01de62
to
f2dc7d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #348
After this changes output will look like:
In yaml format: