Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure noop delete due to terminating namespaces takes into account that a namespace might have been terminated already #1403

Closed
100mik opened this issue Nov 15, 2023 · 0 comments · Fixed by #1404
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed

Comments

@100mik
Copy link
Contributor

100mik commented Nov 15, 2023

What steps did you take:
Delete a namespace with an App scoped to a few namespaces, all of whom are terminating.

What happened:
App did not fallback to noop delete

What did you expect:
App should have ignored finalisers and unblocked ns deletion

Anything else you would like to add:
We need to account for the case where a namespace might be deleted before we check on it's status.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@100mik 100mik added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Nov 15, 2023
@github-project-automation github-project-automation bot moved this to Closed in Carvel Nov 20, 2023
@github-actions github-actions bot removed the carvel-triage This issue has not yet been reviewed for validity label Nov 20, 2023
@renuy renuy added the carvel-accepted This issue should be considered for future work and that the triage process has been completed label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants