Extend noop delete scenario to account for terminated namespaces #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumik Majumder <[email protected]>
100mik
force-pushed
the
fix-noop-delete-due-to-terminating-ns
branch
from
00f8a7e to
ed5cfa3
Compare
rcmadhankumar
pushed a commit
to rcmadhankumar/kapp-controller
that referenced
this pull request
Jan 18, 2024
…vel-dev#1404) Signed-off-by: Soumik Majumder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ensures that App performs a noop delete even when all affected namespaces are terminating, while some might have terminated.
Which issue(s) this PR fixes:
Fixes #1403
Review Checklist:
a link to that PR
change