-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return user friendly error when package doesn't exist #1322
Return user friendly error when package doesn't exist #1322
Conversation
5fb04ee
to
4291bdc
Compare
4291bdc
to
14fb68c
Compare
@100mik @praveenrewar can you review this? |
a7876ac
to
b29b1d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments with some suggested changes for the PR. In general looks good.
Since we are starting to use testify in the tests, it would be good if we did update, at least the test file to use require
instead of the t.Fatalf
.
Signed-off-by: rcmadhankumar <[email protected]>
9cb2cf4
to
86cbc58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does / why we need it:
Return user friendly error when package doesn't exist
Which issue(s) this PR fixes:
Fixes #594
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: