Remove options that can be manipulated downstream #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100mik
force-pushed
the
kctrl-command-tree-changes
branch
from
26610a1 to
dc710e8
Compare
Signed-off-by: Soumik Majumder <[email protected]>
100mik
force-pushed
the
kctrl-command-tree-changes
branch
from
dc710e8 to
db3129d
Compare
praveenrewar
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes options manipulating flag defaults as these can be manipulated downstream using attached pre functions set yup while attaching the command tree
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: