Adding support for tag constraints when adding a package repo with kctrl #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethiyash
force-pushed
the
add-tag-constraints
branch
from
1f93b7d to
aadba40
Compare
rohitagg2020
reviewed
Feb 2, 2024
sethiyash
force-pushed
the
add-tag-constraints
branch
from
aadba40 to
3747ae7
Compare
rohitagg2020
reviewed
Feb 7, 2024
Signed-off-by: Yash Sethiya <[email protected]>
sethiyash
force-pushed
the
add-tag-constraints
branch
from
3747ae7 to
2ea4a9f
Compare
Signed-off-by: Yash Sethiya <[email protected]>
sethiyash
force-pushed
the
add-tag-constraints
branch
from
f68a3d3 to
fbce805
Compare
Signed-off-by: Yash Sethiya <[email protected]>
sethiyash
force-pushed
the
add-tag-constraints
branch
from
fbce805 to
c5beb48
Compare
rohitagg2020
approved these changes
Feb 16, 2024
Signed-off-by: Yash Sethiya <[email protected]>
sethiyash
force-pushed
the
add-tag-constraints
branch
from
b582d38 to
b6d8c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Note: We are only supporting semver when the tag is not present in URL
Which issue(s) this PR fixes:
Fixes #1455
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: