-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new column message in kctrl pkg installed list command #1475
adding new column message in kctrl pkg installed list command #1475
Conversation
371e222
to
4ab281b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should keep the column hidden by default and only display it when any one of the pkgi is failing?
(I am okay if we want to think about that later on based on feedback from users)
4ab281b
to
c84c585
Compare
c84c585
to
3e6016e
Compare
so moved the new column under --wide flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
b8889b2
to
b04992a
Compare
column will be visible when --wide flag is set to true Signed-off-by: Premkumar Bhaskal <[email protected]>
b04992a
to
e99b02f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does / why we need it:
Adding a new column 'Message' in the output of command
kctrl package installed list
, which will show the message from last condition from the status of each package install when --wide flag is provided.The sample output from testing.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: