-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making CRDAppFactory an interface #1498
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Yash Sethiya <[email protected]>
eaa0ae7
to
d46919f
Compare
@@ -21,6 +21,11 @@ import ( | |||
"k8s.io/client-go/kubernetes" | |||
) | |||
|
|||
// ICRDAppFactory interface for CRDAppFactory | |||
type ICRDAppFactory interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICRDAppFactory
Maybe not a good name let me know if you have some better suggestions.
@jorgemoralespou, Is this what you are looking for? |
Yes. Thank you for getting to this so fast. |
LGTM |
// ICRDAppFactory interface for CRDAppFactory | ||
type ICRDAppFactory interface { | ||
NewCRDApp(*kcv1alpha1.App, logr.Logger) *CRDApp | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ICRDAppFactory interface for CRDAppFactory | |
type ICRDAppFactory interface { | |
NewCRDApp(*kcv1alpha1.App, logr.Logger) *CRDApp | |
} | |
// CRDAppCreator interface for CRDAppFactory | |
type CRDAppCreator interface { | |
Create(*kcv1alpha1.App, logr.Logger) *CRDApp | |
} |
What this PR does / why we need it:
Which issue(s) this PR fixes:
#1494
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: