Do not DeepCopy resources in constructors

if the resources are already getting deep copied later on

Signed-off-by: Praveen Rewar <[email protected]>

pkg/kapp/diff/masked_resource.go

@@ -21,7 +21,7 @@ func NewMaskedResource(res ctlres.Resource, rules []ctlconf.DiffMaskRule) Masked
 	if res == nil {
 		panic("Expected res be non-nil")
 	}
-	return MaskedResource{res.DeepCopy(), rules}
+	return MaskedResource{res, rules}
 }
 
 func (r MaskedResource) Resource() (ctlres.Resource, error) {

pkg/kapp/diff/rebased_resource.go

@@ -19,13 +19,6 @@ func NewRebasedResource(existingRes, newRes ctlres.Resource, mods []ctlres.Resou
 		panic("Expected either existingRes or newRes be non-nil")
 	}
 
-	if existingRes != nil {
-		existingRes = existingRes.DeepCopy()
-	}
-	if newRes != nil {
-		newRes = newRes.DeepCopy()
-	}
-
 	return RebasedResource{existingRes: existingRes, newRes: newRes, mods: mods}
 }
 

pkg/kapp/diff/resource_with_removed_fields.go

@@ -13,9 +13,6 @@ type ResourceWithRemovedFields struct {
 }
 
 func NewResourceWithRemovedFields(res ctlres.Resource, mods []ctlres.FieldRemoveMod) ResourceWithRemovedFields {
-	if res != nil {
-		res = res.DeepCopy()
-	}
 	return ResourceWithRemovedFields{res: res, mods: mods}
 }
 

pkg/kapp/resources/resource_with_managed_fields.go

@@ -9,9 +9,6 @@ type ResourceWithManagedFields struct {
 }
 
 func NewResourceWithManagedFields(res Resource, managedFields bool) ResourceWithManagedFields {
-	if res != nil {
-		res = res.DeepCopy()
-	}
 	return ResourceWithManagedFields{res: res, managedFields: managedFields}
 }