Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing redis image in test case #976

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fixing redis image in test case #976

merged 1 commit into from
Jul 4, 2024

Conversation

rohitagg2020
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: Rohit Aggarwal <[email protected]>
@rohitagg2020 rohitagg2020 requested a review from praveenrewar July 4, 2024 10:04
@rohitagg2020 rohitagg2020 merged commit 6e3423a into carvel-dev:develop Jul 4, 2024
6 checks passed
praveenrewar pushed a commit to praveenrewar/kapp that referenced this pull request Jul 9, 2024
Signed-off-by: Rohit Aggarwal <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
praveenrewar pushed a commit to praveenrewar/kapp that referenced this pull request Jul 9, 2024
Signed-off-by: Rohit Aggarwal <[email protected]>

Signed-off-by: Praveen Rewar <[email protected]>
devanshuVmware pushed a commit to devanshuVmware/kapp that referenced this pull request Jul 9, 2024
Signed-off-by: Rohit Aggarwal <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
devanshuVmware pushed a commit to devanshuVmware/kapp that referenced this pull request Jul 9, 2024
Signed-off-by: Rohit Aggarwal <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>
devanshuVmware pushed a commit to devanshuVmware/kapp that referenced this pull request Jul 9, 2024
Signed-off-by: Rohit Aggarwal <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>
rohitagg2020 added a commit that referenced this pull request Jul 11, 2024
* Fixing redis image in test case (#976)

Signed-off-by: Rohit Aggarwal <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>

* Point pinniped registry to ghcr.io (#977)

* Point pinniped registry to ghcr.io

Signed-off-by: devanshuVmware <[email protected]>

* Remove https from image value

Signed-off-by: devanshuVmware <[email protected]>

* Download latest pinniped config for external test

Signed-off-by: devanshuVmware <[email protected]>

---------

Signed-off-by: devanshuVmware <[email protected]>

* Update redis image in gitops example

Signed-off-by: devanshuVmware <[email protected]>

---------

Signed-off-by: Rohit Aggarwal <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>
Co-authored-by: rohitagg2020 <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
rohitagg2020 added a commit that referenced this pull request Jul 11, 2024
* Point pinniped registry to ghcr.io (#977)

* Point pinniped registry to ghcr.io

Signed-off-by: devanshuVmware <[email protected]>

* Remove https from image value

Signed-off-by: devanshuVmware <[email protected]>

* Download latest pinniped config for external test

Signed-off-by: devanshuVmware <[email protected]>

---------

Signed-off-by: devanshuVmware <[email protected]>
Signed-off-by: Praveen Rewar <[email protected]>

* Fixing redis image in test case (#976)

Signed-off-by: Rohit Aggarwal <[email protected]>

Signed-off-by: Praveen Rewar <[email protected]>

---------

Signed-off-by: devanshuVmware <[email protected]>
Signed-off-by: Praveen Rewar <[email protected]>
Co-authored-by: Devanshu <[email protected]>
Co-authored-by: rohitagg2020 <[email protected]>
rohitagg2020 added a commit that referenced this pull request Jul 11, 2024
* Fixing redis image in test case (#976)

Signed-off-by: Rohit Aggarwal <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>

* Point pinniped registry to ghcr.io (#977)

* Point pinniped registry to ghcr.io

Signed-off-by: devanshuVmware <[email protected]>

* Remove https from image value

Signed-off-by: devanshuVmware <[email protected]>

* Download latest pinniped config for external test

Signed-off-by: devanshuVmware <[email protected]>

---------

Signed-off-by: devanshuVmware <[email protected]>

* Update redis image in gitops example

Signed-off-by: devanshuVmware <[email protected]>

---------

Signed-off-by: Rohit Aggarwal <[email protected]>
Signed-off-by: devanshuVmware <[email protected]>
Co-authored-by: rohitagg2020 <[email protected]>
Co-authored-by: Rohit Aggarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants