Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Criterion benchmark #238

Closed
wants to merge 13 commits into from
Closed

Migrate to Criterion benchmark #238

wants to merge 13 commits into from

Conversation

0xethsign
Copy link
Member

Fixes #233

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #238 (0f4a937) into master (1be8610) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   80.25%   79.99%   -0.27%     
==========================================
  Files          22       22              
  Lines        3429     3429              
==========================================
- Hits         2752     2743       -9     
- Misses        677      686       +9     
Impacted Files Coverage Δ
src/effector.rs 74.54% <0.00%> (-3.64%) ⬇️
src/model/default_model.rs 92.58% <0.00%> (-0.90%) ⬇️
src/config.rs 86.33% <0.00%> (-0.63%) ⬇️
src/enforcer.rs 85.54% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be8610...0f4a937. Read the comment docs.

@hackerchai
Copy link
Member

hackerchai commented Mar 28, 2021

We also need automatic github actions support, you can refer this criterion-compare-action. @smrpn

@hackerchai
Copy link
Member

@smrpn And please always sign-offf your commits

@0xethsign
Copy link
Member Author

We also need automatic github actions support, you can refer this criterion-compare-action. @smrpn

noted

@hsluoyz
Copy link
Member

hsluoyz commented Mar 30, 2021

The git history is so messed up. Closed here.

image

@hsluoyz hsluoyz closed this Mar 30, 2021
@0xethsign 0xethsign deleted the criterionrs branch March 30, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Criterion benchmark
3 participants