Add a version skipping mechanism for the AGP patch #111
Conversation
| // Do a strict version check to ensure that our monkey-patching will work correctly. | ||
| check(Version.ANDROID_GRADLE_PLUGIN_VERSION == TARGET_AGP_VERSION) { | ||
| "This version of the Android Gradle Plugin (${Version.ANDROID_GRADLE_PLUGIN_VERSION}) is not supported by the better-dynamic-features plugin. Only version $TARGET_AGP_VERSION is supported." | ||
| target.afterEvaluate { |
There was a problem hiding this comment.
any chance this might not be needed, given that this callback should be called only when modules apply the application plugin? i'm always reluctant to add more afterEvaluate blocks 😓
There was a problem hiding this comment.
or maybe push it out of here into its own global check, if it'd be a good idea to ensure an Android plugin is always applied for a module applying this plugin:
There was a problem hiding this comment.
In our use case, the agp-patch plugin is only applied to our main application module so that this version check runs.
The actual work of applying the "patch" is done by just including the plugin on the build classpath.
technically this block will also only run if the com.android.application plugin is applied in the first place! (there's a plugins.withId() block)
Usage: BDF targets 8.2.1 and you want to upgrade to 8.2.2 which you know is safe
betterDynamicFeaturesPatch { suppressVersionCheck("8.2.2") }