Re-add example CI #77
Merged
+49
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! I know @NickEntin has been excited about upgrading the snapshot images to latest as well. Certainly not the easiest lift. |
NickEntin
approved these changes
Sep 25, 2024
|
@luispadron Looks like I was removed as an admin on the repo - can you add me back or mark the |
|
Thanks for getting this updated! Added @dfed as maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75 removed CI for the example because they had gone stale and GitHub workers no longer support iOS 13 or
macos-11. To not block other work (such as better support for SPM) I removed these tests. We should ideally continue to test the examples but requires more work.This will require updates to support one of the macos & iOS platforms available to GitHub action workers: https://github.com/actions/runner-images/tree/main/images/macos We'll also need to update snaphot images.