crawB Binary Token Serialization
#507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It looks like the plan is to remove support for V3 token binary cashubtc/nuts#202 so I think we should remove it here before merging to avoid having to take it out later.
lollerfirst
changed the title
craw(A|B) Binary Token SerializationcrawB Binary Token Serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADDED
Token::to_raw_bytesserializes generic token to raw bytes, choosing between a TokenV3 or TokenV4 serialization.Token::try_fromforVec<u8>constructs a generic token from raw bytes.TokenV3::to_raw_bytesserializes a TokenV3 to raw bytes following the spec.TokenV3::fromforVec<u8>constructs a TokenV3 from raw bytes.TokenV4::to_raw_bytes()serializes a TokenV4 to raw bytes following the spec.TokenV4::fromforVec<u8>constructs a TokenV4 from raw bytes.Wallet::receive_rawwhich receives raw binary tokens.