-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On chain mint and melt #194
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Steffen <[email protected]>
{ | ||
"amount": <int>, | ||
"unit": <str_enum["sat"]>, | ||
"pubkey": <str> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NUT-19 says this should be optional, depending on whether or not the MintInfo
requires it.
{ | ||
"quote": <str>, | ||
"outputs": <Array[BlindedMessage]>, | ||
"witness": <str> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well. It's not clear if this NUT requires a Mint that requires NUT-19 signatures or only supports them.
@thesimplekid Why do we need new NUTs for this? Can't we just add some appendices to NUT-3, NUT-4 and NUT-5 on what additional fields a particular We can then modify NUT-6 to include information about a particular minting and melting method called
|
I think its a reasonable question, and one way to do it. But I don't really think we should be changing or adding to past nuts. I think it gets confusing, its better to just have new nuts. That being said maybe what id defined in the new nuts could be reduced and and reference the existing nuts and some of it is repetitive. Though I did it this way because this way the nut stands more on its own and you don't have to check another nut as much. But think there are arguments for and against that |
NUTs 3, 4 and 5 are mandatory. Adding optional fields to them feels wrong. Also on-chain minting has some specifics (and we already see that via quote locking) and therefore I think this deserves another pair of NUTs. I would like to also see Liquid supported and I feel this should be again another pair of NUTs, although the distinction here is probably not that strong and Liquid support can become a part of the BTC on-chain NUTs. |
```json | ||
{ | ||
"quote": <str>, | ||
"address": <str>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"address": <str>, | |
"request": <str>, |
since in other places throughout this NUT request
is being used rather than address
### Witness | ||
|
||
In order to mint ecash the wallet **MUST** include a signature as defined in [NUT-19][19]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be moved to the Minting tokens
section where this field is used in the request.
Depends on #188
Supersedes #107