{WIP} add abstraction over builders for 1.5 and 2.0 #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor
reviewed
Jan 20, 2025
src/utils/cspr-network.ts
Outdated
| .byHash(contractHash) | ||
| .entryPoint('redelegate') | ||
| .chainName(networkName) | ||
| // .amount(amountMotes) |
ihor
reviewed
Jan 20, 2025
src/utils/cspr-network.ts
Outdated
| .buildFor1_5(); | ||
| } | ||
|
|
||
| return new Error('Need to provide contract hash'); |
There was a problem hiding this comment.
Let's change to Auction contract hash is required when creating a transaction on Casper Network 1.5.x
ihor
reviewed
Jan 20, 2025
src/utils/cspr-network.ts
Outdated
| amountMotes: string | BigNumber, | ||
| deployCost: number, | ||
| ttl: number, | ||
| contractHash?: string |
ihor
reviewed
Jan 20, 2025
src/utils/cspr-network.ts
Outdated
| .buildFor1_5(); | ||
| } | ||
|
|
||
| return new Error('Need to provide contract hash'); |
There was a problem hiding this comment.
Let's change to Auction contract hash is required when creating a transaction on Casper Network 1.5.x
ihor
reviewed
Jan 20, 2025
src/utils/cspr-network.ts
Outdated
| amountMotes: string | BigNumber, | ||
| deployCost: number, | ||
| ttl: number, | ||
| contractHash?: string |
ihor
reviewed
Jan 20, 2025
ihor
reviewed
Jan 20, 2025
ihor
reviewed
Jan 20, 2025
ihor
reviewed
Jan 20, 2025
| return await this.rpcClient.getTransactionByDeployHash( | ||
| hash.deploy.toHex() | ||
| ); | ||
| } |
There was a problem hiding this comment.
I suppose this section should go inside the version 2 condition and the getDeploy RPC method to be used for 1.5.x
ihor
requested changes
Jan 20, 2025
There was a problem hiding this comment.
@eugenebelov could you please also add return types to all methods
ihor
reviewed
Jan 20, 2025
ihor
requested changes
Jan 21, 2025
davidatwhiletrue
approved these changes
Jan 21, 2025
alexmyshchyshyn
approved these changes
Jan 22, 2025
ihor
reviewed
Jan 22, 2025
ihor
approved these changes
Jan 22, 2025
Comp0te
approved these changes
Jan 22, 2025
eugenebelov
deleted the
feature/CSDK-206-add-abstraction-over-builders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.