Changed the way transaction lanes are calculated if the transaction h… #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
transaction_size_estimate_should_use_payment_for_limited_pricing
branch
2 times, most recently
from
e8240d5 to
a74c727
Compare
…as PricingMode::PaymentLimited. For wasm based transaction with that pricing mode the payment_amount field will be used as size estimate to determine the wasm lane. Also added some validation for the chainspec to prevent: * wasm lanes using reserved ids (mint, auction, install/upgrade) * wasm lanes that have duplicate max_transaction_length * wasm lanes that have duplicate max_transaction_gas_limit * configs that have no wasm lanes defined
zajko
force-pushed
the
transaction_size_estimate_should_use_payment_for_limited_pricing
branch
from
a74c727 to
01968e7
Compare
zajko
requested review from
mpapierski,
darthsiroftardis,
EdHastingsCasperAssociation and
wojcik91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as PricingMode::PaymentLimited. For wasm based transaction with that pricing mode the
payment_amountfield will be used as size estimate to determine the wasm lane.Also added some validation for the chainspec to prevent:
This PR might have impact on casper-client-rs