feat: TypeMeta as primary object Kind value source #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pijusn-cast
requested review from
saumas,
mindaugasCast,
dariuspie,
zilvinasu,
KarolisL,
mikenorgate,
jakubsolecki,
vladklokun,
linkas45,
laimonasr and
kasia-kujawa
as code owners
KarolisL
approved these changes
Nov 4, 2024
pijusn-cast
added a commit
that referenced
this pull request
Nov 7, 2024
This reverts commit ab92482.
pijusn-cast
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't observe any errors with this in almost a week. While there is a limited expose (slow version rollout), I think this should be enough to merge this change and continue using the TypeMeta information for the cache key (deduplication) and Kind value.
Overall, this is part of the move to use generic
Unstructuredruntime type for some of the objects collected.