feat: TypeMeta as primary object Kind value source #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 98d248f.
pijusn-cast
requested review from
saumas,
mindaugasCast,
dariuspie,
zilvinasu,
KarolisL,
mikenorgate,
jakubsolecki,
vladklokun,
linkas45,
laimonasr and
kasia-kujawa
as code owners
mikenorgate
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was already merged and then reverted when we noticed an issue. However, after looking into it more, I found out that the problem was outside this change. Also, I manually tested this commit to confirm that the specific object that we had issue with was included in the deltas produced by the agent.
I intend to get this merged and then manually override agent image in our clusters in order to have one more level of verification before releasing it through the Helm.