chore: Add unit test for PodMetrics object informer #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pijusn-cast
requested review from
saumas,
mindaugasCast,
dariuspie,
zilvinasu,
KarolisL,
mikenorgate,
jakubsolecki,
vladklokun,
linkas45,
laimonasr and
kasia-kujawa
as code owners
KarolisL
reviewed
Nov 18, 2024
| @@ -182,7 +183,7 @@ func TestController_ShouldReceiveDeltasBasedOnAvailableResources(t *testing.T) { | |||
| item.Data != nil && | |||
| strings.Contains(string(*item.Data), expectedGVString) // Hacky but OK given this is for testing purposes. | |||
| }) | |||
| require.True(t, found) | |||
| require.Truef(t, found, "missing object for %s %s", expectedGVString, expected.Kind) | |||
There was a problem hiding this comment.
If there was an empty string, %q would produce an error msg that is easier to understand.
There was a problem hiding this comment.
I don't think it can be empty right now but replaced it. Maybe it will be some time or when something breaks.
KarolisL
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was missing. While it doesn't cover everything related, this verifies at least some informer basics.