Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R/O Onboarding example for AKS #230

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Add R/O Onboarding example for AKS #230

merged 4 commits into from
Oct 16, 2023

Conversation

CastAIPhil
Copy link
Contributor

@CastAIPhil CastAIPhil commented Oct 11, 2023

Add a read-only example for customers

@CastAIPhil CastAIPhil requested a review from a team as a code owner October 11, 2023 21:12
@@ -0,0 +1,14 @@
locals {
role_name = "CastAKSRole-${var.cluster_name}-tf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local variables aren't used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the unused variables, I'm not sure how to fix the SDK thing on the checks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate-sdk

@CastAIPhil CastAIPhil merged commit 3ed7998 into master Oct 16, 2023
9 checks passed
@CastAIPhil CastAIPhil deleted the aks-read-only branch October 16, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants