feat: add support for setting node affinity selectors for dedicated n… #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenorgate
force-pushed
the
dedicate-node-affinity-selectors
branch
from
620d7ce to
a58d038
Compare
jansyk13
reviewed
Apr 11, 2024
castai/resource_node_template.go
Outdated
| @@ -368,10 +382,37 @@ func resourceNodeTemplate() *schema.Resource { | |||
| Description: "Availability zone name.", | |||
| }, | |||
| FieldNodeTemplateName: { | |||
| Required: true, | |||
| Optional: true, | |||
There was a problem hiding this comment.
Yes, you don't need to provide the dedicated node group name if you are using the selectors
jansyk13
reviewed
Apr 11, 2024
|
Make sure to update TF GKE module as well |
jansyk13
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…odes