Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIRE-839: add service account keys support #431

Merged
merged 29 commits into from
Dec 16, 2024

Conversation

radekska
Copy link
Contributor

@radekska radekska commented Dec 10, 2024

  • resource implementation for castai_service_account_key
  • minor tweaks for castai_service_account resource

@radekska radekska changed the base branch from master to rskalbania/wire-839/service.accounts December 10, 2024 07:59
@radekska radekska changed the title Rskalbania/wire 839/service.accounts.keys WIRE-839: add service account keys support Dec 11, 2024
@radekska radekska marked this pull request as ready for review December 11, 2024 16:22
@radekska radekska requested a review from a team as a code owner December 11, 2024 16:22
Copy link
Member

@oskarwojciski oskarwojciski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some example of working with keys, also how to obtain the key token value while creating it?

I wonder if we want to split the resources or make the keys part of the resource_service_account. They are separated in the API, but logically, they are very much connected.

castai/resource_service_account.go Outdated Show resolved Hide resolved
Base automatically changed from rskalbania/wire-839/service.accounts to master December 12, 2024 08:20
@radekska
Copy link
Contributor Author

Can you add some example of working with keys, also how to obtain the key token value while creating it?

Examples added

I wonder if we want to split the resources or make the keys part of the resource_service_account. They are separated in the API, but logically, they are very much connected.

I thought about the same and decided to follow GCP approach:

@oskarwojciski
Copy link
Member

I see that we show change state for the name change, but we don't allow to update it, so it never apply
image
should we add ForceNew flag for name, and the service_account_id fields? Same as for expires_at which works fine

@radekska radekska merged commit c7f19ff into master Dec 16, 2024
10 checks passed
@radekska radekska deleted the rskalbania/wire-839/service.accounts.keys branch December 16, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants