Add docker support with a Dockerfile and Github Actions to automatically build and push the docker on the main branch. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First, just wanted to say thanks for the project.
This is a PR to add docker support using a Dockerfile. I've also added github actions to build and push the build automaticaly into the docker registry of the project. Builds are only done on the main branch.
To test, you can use my docker package link :
docker run -v path/to/routeros.rsc:/config/routeros.rsc ghcr.io/ncareau/sara:mainLet me know if you have changes you want or any questions.