-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(port, content): freshwater research station #3762
Conversation
Several of the roof appliances had t_open_air beneath them. Change fill_ter to roof to prevent that.
heccin' case-sensitive semantic PR thing |
average CapitalCase fan vs average lowercase enjoyer EDIT: |
Whoops, nice. That explains why it was failing, and glad it successfully checked itself off once corrected. |
hopefully semantic PR bot will be a more helpful after #3672. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e038b1c
Purpose of change
Freshwater Research Station is a neat special to have.
It's mostly JSON thing, but also includes tiny yet vital C++ change, required for all other underwater specials(aircraft carrier).
Describe the solution
Ported PRs:
With minimal changes:
t_door_metal_bulkhead_o
increased from 1 to 2. Such doors are not allowed in BN. (Add check for suspicious move_cost in terrain #2252)"city_sizes": [ 1, 20 ]
which does pretty much nothing, except confusing mapgen.Describe alternatives you've considered
Also porting vertical swimming, and two way ladders. Both are good, but not directly related - they will be ported separately.
Testing
Spawned via debug; found naturally generated one; started in it from Safe Place scenario. All works.
Additional context
Checklist