Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Make slimesprings avoid traps #3795

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

RobbieNeko
Copy link
Collaborator

@RobbieNeko RobbieNeko commented Dec 1, 2023

Purpose of change

As pointed out by a member in the Discord, slimesprings don't currently avoid traps. Fixing this seems like a no-brainer to me, since I doubt it's intended for the cute lil guys to be walking into traps like that.

Describe the solution

Adds "PATH_AVOID_DANGER_1" to the slimespring. This should fix the issue, assuming this flag does what I assume it does.

Describe alternatives you've considered

None

Testing

Admittedly, none. However, I hope this is a simple enough fix that, in the words of a certain man, "It just works."

Additional context

Another user suggested changing the aggression of the slimesprings so that they aren't so hostile towards non-hostile monsters, but I have no clue what the correct aggression value for that would be.

At least I *think* that's what this flag does
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 1, 2023
@RobbieNeko
Copy link
Collaborator Author

image
Considering that discussion only focuses on the aggression, which I didn't touch, feels a bit weird to put that there.

@scarf005
Copy link
Member

scarf005 commented Dec 2, 2023

sorry, got confused because both touched slimespring.

@RobbieNeko
Copy link
Collaborator Author

Understandable, especially considering how I actually mention it in the Additional Context haha

Thanks Chaos, very cool

Co-authored-by: Chaosvolt <[email protected]>
@chaosvolt chaosvolt added this pull request to the merge queue Dec 2, 2023
Merged via the queue into cataclysmbnteam:upload with commit 58294c5 Dec 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants