Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove active iterator messages #3801

Merged

Conversation

joveeater
Copy link
Collaborator

Purpose of change

Fixes #3790 and probably a host of other similar problems

Describe the solution

Get rid of them.

@github-actions github-actions bot added the src changes related to source code. label Dec 2, 2023
@scarf005 scarf005 self-requested a review December 2, 2023 09:55
@scarf005 scarf005 self-assigned this Dec 2, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-12-02_19-04-26.mp4
  1. created wood loot and chop trees zone with (P).
  2. attempted to use both action (O).
  3. nothing happens.

@joveeater
Copy link
Collaborator Author

@scarf005 I couldn't reproduce this. I very much doubt it's due to this pr as this is only removing those messages. Try it out on upload and see if it still exists there.

@scarf005 scarf005 enabled auto-merge December 2, 2023 11:09
@scarf005 scarf005 added this pull request to the merge queue Dec 2, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-12-02_20-06-52.mp4

I've just tried again and it works now. I was also unable to reproduce the original issue. My guess is on some specific cases zone activities silently fails without any error messages.

Merged via the queue into cataclysmbnteam:upload with commit 22b52f8 Dec 2, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active Iterator Error on Zone Farming, Zone Wood Chopping, Transferring Liquids
2 participants