Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: bring aoe shotshell again #4950

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Jul 7, 2024

Checklist

Required

Purpose of change

Describe the solution

WIP, need to figure out why ammo effects doesn't work

it's been half years and we might want to merge it first and think of bugs afterwards since players seem to want it.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Jul 7, 2024
@scarf005 scarf005 marked this pull request as ready for review January 12, 2025 14:26
@scarf005 scarf005 force-pushed the feat/bring-aoe-back branch from e9ec247 to 5e56ac1 Compare January 12, 2025 15:15
@scarf005 scarf005 changed the title feat: bring aoe shotshell again revert: bring aoe shotshell again Jan 12, 2025
@chaosvolt
Copy link
Member

Since the most disruptive bug with AoE ammo got fixed it's probably fine then, true. I'll have to see about compile-testing the C++ changes on this, I assume that's aimed at fixing the ammo effect issues?

@scarf005
Copy link
Member Author

scarf005 commented Jan 12, 2025

Since the most disruptive bug with AoE ammo got fixed it's probably fine then, true. I'll have to see about compile-testing the C++ changes on this, I assume that's aimed at fixing the ammo effect issues?

nope, ammo effects hasn't been fixed, it merely reverts ammo types so e.g dragon breath still won't work

@chaosvolt
Copy link
Member

nope, ammo effects hasn't been fixed, it merely reverts ammo types so e.g dragon breath still won't work

Uhhhh. You have two C++ changes in your PR here. I'm asking what do they do, since the PR description doesn't really say anything about that?

@scarf005 scarf005 merged commit af3b299 into cataclysmbnteam:main Jan 13, 2025
16 checks passed
@scarf005 scarf005 deleted the feat/bring-aoe-back branch January 13, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back AOE ammos
2 participants