Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gun type shorthands #5796

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Dec 6, 2024

Checklist

Required

Optional

  • This is a C++ PR that modifies JSON loading or behavior.
    • I have documented the changes in the appropriate location in the doc/ folder.
    • If documentation for this feature does not exist, please write it or at least note its lack in PR description.
    • New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
    • If applicable, add checks on game load that would validate the loaded data.

Purpose of change

UI based approach to #4299

Describe the solution

wip

Describe alternatives you've considered

Testing

Cataclysm: Bright Nights - 0 C-58339-g4fe00c58c972_02

Additional context

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant