Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix NPC laser finger infinite loop #5798

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Coolthulhu
Copy link
Member

Checklist

Required

Optional

Purpose of change

Fix #5788

Describe the solution

In npc::aim, the NPC would use currently equipped weapon without doing a check for existing fake weapon. Added the check for fake weapon and allowed the NPC to aim that first.
Also added a check for infinite aiming loop. Doesn't fix anything, but will print a helpful debugmsg if infinite aiming loop ever happens again.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added the src changes related to source code. label Dec 9, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@chaosvolt chaosvolt merged commit 47757d2 into cataclysmbnteam:main Dec 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPCs enter infinite loop when attempting to fire Finger Laser
2 participants