Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More electric motor recipes #5805

Merged
merged 9 commits into from
Dec 21, 2024

Conversation

Berehenia
Copy link
Contributor

Add recipes for the electric motor, large electric motor, enhanced electric motor, and super electric motor

Checklist

Required

Optional

Purpose of change

Electric motors above small tier are not craftable, you can only find them by sheer luck most of the time. Adding recipes to them that are roughly based on their disassembled amounts (and a bit more) would make it less obnoxious for the players. Not sure about balancing the super motor at 7 but yeah, that's up in the air.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Add recipes for the electric motor, large electric motor, enhanced electric motor, and super electric motor
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 13, 2024
Copy link
Contributor

autofix-ci bot commented Dec 13, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt
Copy link
Member

Enhanced electric motor is made of superalloy, so swapping the steel for allow sheets might be a good idea.

@RoyalFox2140
Copy link
Collaborator

I feel the recipes are a too cheap, and a little too easy in skills. A super motor should probably take at least 8 or 9 electronics. They don't seem to take mechanics either like an engine would need.

@karxi
Copy link
Contributor

karxi commented Dec 13, 2024

If the enhanced motor is made of superalloy, the super motor definitely should be.
Mechanics seems reasonable (though probably at a lower skill requirement than installing one) given the increased size and particular purpose of the large, enhanced, and super engines.

I think pure Electronics and Fabrication is still fine for normal ones, but enhanced motors are valuable and especially useful.
Super motors are virtually unheard of—they're extremely specialized equipment used only in electric racing cars and atomic helicopters—so a recipe to make them should probably be top-tier/endgame skills.

@RoyalFox2140
Copy link
Collaborator

Yeah only Super/Enhanced needs Mechanics, primarily due to how insane they are in vehicles, lower skill is also ok, since it relies on electronics.

@karxi
Copy link
Contributor

karxi commented Dec 13, 2024

The times for these could probably use adjustment too. An hour is not very long for (again) making an engine that can power a small helicopter. There are characters that might only ever need one or two super engines. They should be time-consuming and resource intensive (particularly since, again, endgame) to make.
It'd likely also be wise to raise the skill it takes to learn the recipes according to how hard they are; 2 across the board is very low.

@Berehenia
Copy link
Contributor Author

Berehenia commented Dec 14, 2024

Hi, just woke up
Skills can be jacked up, time can be jacked up as well but I don't know what's appropriate, so here's a suggestion :

5 both for large, 8hr crafting
6 elec 6 fab for enhanced, 10 hour crafting
8 elec 8 fab for super, 15 hour crafting

Super, even if it is complex wouldn't be more complex than most cbms, right?

The enhanced motor, even if it's superalloy base, does not give any when it's disassembled, so I didnt put any in the recipe, so it's up to others whether we swap out it's material or it's crafting recipe

Edit: as for mats, they're roughly how much they would give based off their breaks_into/disassembled amounts, so maybe add something rare to it, as for what, i dont know.

@Berehenia
Copy link
Contributor Author

@chaosvolt
Copy link
Member

The enhanced motor, even if it's superalloy base, does not give any when it's disassembled, so I didnt put any in the recipe, so it's up to others whether we swap out it's material or it's crafting recipe

Weird, I couldn't find an uncraft for it. o.O

Berehenia and others added 2 commits December 15, 2024 14:26
Higher recipe costs, more qualities for super and enh required, some superalloy added for them
Copy link
Contributor

@karxi karxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed my errors with the lumps of steel, as well as the soldering_standard counts. I've tried all of these ingame, so if you choose to use them, they do work as-is.

I hope this is satisfactory!

data/json/recipes/electronic/components.json Outdated Show resolved Hide resolved
data/json/recipes/electronic/components.json Outdated Show resolved Hide resolved
data/json/recipes/electronic/components.json Outdated Show resolved Hide resolved
data/json/recipes/electronic/components.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but I need opinion from @chaosvolt

The motor oil is a weird stand in for lubricant but I don't think we gain enough modeling a new item for just electric motors.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from a quick look over them they seem okay, far as I can tell. Difficulty could potentially be bumped up a bit but they aren't too bad I don't think.

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some possible balance tweaks one could make though.

@chaosvolt
Copy link
Member

Eh, the above suggestions have been mused upon on he discord and objected to abit, plus Coolthulhu's mention that the proposed increase in difficulty may be a bit much, so is probably fine as-is instead.

@chaosvolt chaosvolt merged commit 619ddbf into cataclysmbnteam:main Dec 21, 2024
13 checks passed
@Ker-Nes
Copy link
Contributor

Ker-Nes commented Dec 24, 2024

Given how a generator and an electric motor are in many ways basically the same thing operating in opposite directions, should we also have a recipe for the 7.5kW Generator? Might, among other things, make fueled power a bit more common by not depending on finding one or only being able to use vehicle alternators instead.

Also, maybe having more size of generators too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants