Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort body parts in Character::get_all_body_parts #5835

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Coolthulhu
Copy link
Member

Checklist

Required

Optional

Purpose of change

Fix #5778

Describe the solution

Sort body parts in the vector returned by Creature::get_all_body_parts. Order is defined in json.

Describe alternatives you've considered

  • Sort it in some other place
  • Have torso go before head in sort order

Testing

Additional context

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Dec 26, 2024
@Coolthulhu Coolthulhu changed the title Sort body parts in Character::get_all_body_parts fix: Sort body parts in Character::get_all_body_parts Dec 26, 2024
@chaosvolt chaosvolt merged commit 099aeff into cataclysmbnteam:main Dec 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classic view shows incorrect body part for damage amounts.
3 participants