fix: folding vehicles fold up into proper item #5845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
Allows folding a vehicle to work (presumably) as intended, and return the specified item. Previously, if someone added a new item
"skateboard"
and refolded it after placing it down, it would return a folding_bicycle item. Now it will return the"skateboard
" item. Also changes name of the folding wheelchair, and the way folding vehicle names are created. Previously it would fold into "folded Folding wheelchair" now just into "wheelchair."Describe the solution
Unhardcode the string
"folding_bicycle"
and make it returnitype_id
instead when specifying thefolding_veh_item
.Describe alternatives you've considered
Testing
Spawned unicycle and wheelchair, they work as expected upon folding/unfolding. Spawned a folding_bicycle item, works as expected. Created a test item folding_flatbed which unfolds into a flatbed truck, and upon it being refolded it correctly returns the folding_flatbed.
Additional context