-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): Rebalance Tree Spawns #5853
Conversation
Attempt 1
Ehhh, to be honest this is one Viss PR I'm okay with. Bushes and trees are plenty common even after that PR. Granted, the changes in this aren't THAT severe so it's probably fine either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was fine with the pre-nerf values as they were, so I'm in favor of this, key highlights of the problem is that:
- At the current odds for fruit trees relative to all others, they are effectively lost content
- Mobile users will have to generate a huge amount of forest to survive, generation effects everyone but it barely affects PC users.
- Most trees being elm limits biodiversity in a very strange way. It feels off.
Main thing I'm doing is cutting dramatically back on the elms because 256 was a very high number for a single random tree type. Also, everything except pine in terms of food trees felt super rare to me? So I'm still not entirely sure I don't want to bump them back up a bit more, but definitely NEVER going back to pre-nerf t_tree values thanks to those acorns. I'm aiming for compromise / a middle ground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¯\(ツ)/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally cut back the pine tree spawns a little, they feel kind of common and they're a bit stronger than other food trees and bushes thanks to spawning their high-calorie 'fruit' once a season instead of one season a year. Other than that, it seems good to me.
Also valid, it's a bit weird how their bit of the distribution actually got buffed with the prior PRs while the rest of the nuts went down |
8beab3f
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
It has been noted that after #4399 and #4405 , foraging has been kind of meh. In particular, I noticed a dramatic spam in dead trees and elm trees. This attempts to remedy the issues I see with the approach in those PRs while also aiming for a compromise between how they currently are and how they were.
Describe the solution
t_tree
, reverts changes to fruit treesDescribe alternatives you've considered
I'm still tempted tbh, not entirely sure I'm happy with the current results.
Feels unnecessary, and to be fair nut foraging was very good before.
Testing
Before this PR (aka with the 2 aforementioned PRs):
After:
World is as default as can be, and the world was "reset" for the purposes of regenerating in order to get the After images.
Additional context
Input is highly appreciated!