Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Rebalance Tree Spawns #5853

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

RobbieNeko
Copy link
Collaborator

Checklist

Required

Purpose of change

It has been noted that after #4399 and #4405 , foraging has been kind of meh. In particular, I noticed a dramatic spam in dead trees and elm trees. This attempts to remedy the issues I see with the approach in those PRs while also aiming for a compromise between how they currently are and how they were.

Describe the solution

  • Greatly reduces elm spawn rate
  • Slightly increase t_tree, reverts changes to fruit trees
  • Slightly reduce pine numbers
  • Slightly reduce dead tree spam

Describe alternatives you've considered

  • Go for a more aggressive approach closer to how they were before aforementioned PRs

I'm still tempted tbh, not entirely sure I'm happy with the current results.

  • Completely revert the PRs

Feels unnecessary, and to be fair nut foraging was very good before.

Testing

Before this PR (aka with the 2 aforementioned PRs):
image
image

After:
image
image

World is as default as can be, and the world was "reset" for the purposes of regenerating in order to get the After images.

Additional context

Input is highly appreciated!

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 30, 2024
@chaosvolt
Copy link
Member

chaosvolt commented Dec 30, 2024

Ehhh, to be honest this is one Viss PR I'm okay with. Bushes and trees are plenty common even after that PR. Granted, the changes in this aren't THAT severe so it's probably fine either way.

RoyalFox2140
RoyalFox2140 previously approved these changes Dec 30, 2024
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was fine with the pre-nerf values as they were, so I'm in favor of this, key highlights of the problem is that:

  1. At the current odds for fruit trees relative to all others, they are effectively lost content
  2. Mobile users will have to generate a huge amount of forest to survive, generation effects everyone but it barely affects PC users.
  3. Most trees being elm limits biodiversity in a very strange way. It feels off.

@RobbieNeko
Copy link
Collaborator Author

Main thing I'm doing is cutting dramatically back on the elms because 256 was a very high number for a single random tree type.

Also, everything except pine in terms of food trees felt super rare to me? So I'm still not entirely sure I don't want to bump them back up a bit more, but definitely NEVER going back to pre-nerf t_tree values thanks to those acorns. I'm aiming for compromise / a middle ground.

scarf005
scarf005 previously approved these changes Dec 30, 2024
chaosvolt
chaosvolt previously approved these changes Dec 30, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\(ツ)

Copy link
Collaborator

@yay855 yay855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally cut back the pine tree spawns a little, they feel kind of common and they're a bit stronger than other food trees and bushes thanks to spawning their high-calorie 'fruit' once a season instead of one season a year. Other than that, it seems good to me.

@RobbieNeko
Copy link
Collaborator Author

Also valid, it's a bit weird how their bit of the distribution actually got buffed with the prior PRs while the rest of the nuts went down

@RobbieNeko RobbieNeko dismissed stale reviews from chaosvolt, scarf005, and RoyalFox2140 via 8beab3f December 31, 2024 00:29
@scarf005 scarf005 merged commit 9ad2f7b into cataclysmbnteam:main Jan 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants