Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle "relative" and "proportional" with encumbrance #5858

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Coolthulhu
Copy link
Member

Checklist

Required

Optional

Purpose of change

Fix #3861

Describe the solution

Use assign in a hacky way to have it handle the fields properly.

  • Add tests that confirm it works

Describe alternatives you've considered

Revert the armor portions thing - it won't help us much, but it is certain to cause trouble until we rewrite the jsons to the new format.

Testing

  • Spawn chitin gauntlets and biosilicified chitin gauntlets
  • Compare encumbrance - biosilicified should have 15 encumbrance, while regular should have 10
  • Load world with Magiclysm
  • Spawn chitin gauntlets and demon chitin gauntlets
  • Demon chitin gauntlets should have 9 encumbrance, while regular should have 10

Additional context

@github-actions github-actions bot added the src changes related to source code. label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proportional and relative no longer update encumbrance at all
1 participant