Feed download fix #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abyrd
requested changes
Apr 13, 2017
| @@ -7,22 +7,22 @@ cache: | |||
| directories: | |||
| - "$HOME/.m2/repository" | |||
| before_install: | |||
| - sed -i.bak -e 's|https://nexus.codehaus.org/snapshots/|https://oss.sonatype.org/content/repositories/codehaus-snapshots/|g' | |||
| ~/.m2/settings.xml | |||
| #- sed -i.bak -e 's|https://nexus.codehaus.org/snapshots/|https://oss.sonatype.org/content/repositories/codehaus-snapshots/|g' ~/.m2/settings.xml | |||
There was a problem hiding this comment.
We need comments in this file explaining what the shell commands do.
|
@zbouziane and @abyrd, I'm going to go ahead and add more comments, fix the conflicts and merge to avoid this branch getting any staler. |
landonreed
force-pushed
the
feed-download-fix
branch
from
cf3d6f4 to
fd0994b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend changes for #1.
This PR, in conjunction with catalogueglobal/datatools-ui#4, allows for the direct download of feeds from s3 using Temporary Security Credentials (new role in AWS IAM must be created). Rather than using tokens to download feeds (a method which is still used when not using s3), this approach issues credentials to users for the requested feed, which are then used by the client to download the feed from s3.