Add NREL Siting Lab dataset archiver #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmgosnell
requested changes
Feb 13, 2025
Comment on lines
88
to
99
| # A few datasets have an additional linked data page: | ||
| # e.g., https://data.openei.org/submissions/1932 | ||
| additional_datasets_pattern = re.compile(r"\/submissions\/\d{4}") | ||
| links = await self.get_hyperlinks(dataset_link, additional_datasets_pattern) | ||
|
|
||
| # For each additional dataset linked, iterate through the same process | ||
| for link in links: | ||
| additional_dataset_id = link.split("/")[-1] | ||
| additional_data_paths_in_archive = await self.download_nrel_data( | ||
| dataset_id=additional_dataset_id, dataset_link=link | ||
| ) | ||
| data_links.update(additional_data_paths_in_archive) |
There was a problem hiding this comment.
this is a nit but i think this would seem more reasonable to happen in download_nrel_data where all the other links are being compiled
e-belfer
force-pushed
the
nrel-supply-curves
branch
from
03e813f to
c0f0df6
Compare
e-belfer
force-pushed
the
nrel-supply-curves
branch
from
c0f0df6 to
fce903b
Compare
cmgosnell
approved these changes
Feb 19, 2025
|
|
||
| name: str = "nrelsiting" | ||
| base_url: str = "https://data.openei.org/siting_lab" | ||
| concurrency_limit = 1 # The server can get a bit cranky, so let's be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #584
What problem does this address?
What did you change in this PR?
Questions for the reviewer:
working_partitionsblank in thedatapackage.jsonfile because I dynamically generate all the URLs. Is this a problem if we aren't planning to access the data through our datastore?Testing
How did you make sure this worked? How can a reviewer verify this?
https://github.com/catalyst-cooperative/pudl-archiver/actions/runs/13296766499
To-do list
Tasks