Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compatibility with Moodle 4.0 & update Unit tests #7

Open
wants to merge 23 commits into
base: MOODLE_311_STABLE
Choose a base branch
from
Open

Ensure compatibility with Moodle 4.0 & update Unit tests #7

wants to merge 23 commits into from

Conversation

Badatos
Copy link

@Badatos Badatos commented Nov 24, 2022 •
edited
Loading

Hello ! Thanks for this plugin.
Here are some changes to ensure compatibility with Moodle 4.0, and update all units tests:

  • Add php 8.0 and Moodle 4.0 to github CI
  • SET max_input_vars PHP value required for Moodle 4.0
  • Remove some errors and warnings from codechecker
  • Remove unnecessary "defined('MOODLE_INTERNAL') || die();"
  • Format README.txt in markdown
  • Upgrade github actions, grunt and node.js versions
  • Remove some phpdoc errors
  • Display debugging message when download_file_content can't reach an url (can happend with SSL errors)
  • Remove Poll EveryWhere from Unit Tests, as they no more features oembed.

Badatos added 23 commits November 16, 2022 12:12
@Badatos
Remove some errors and warnings from codechecker
cc4a621 
+ format README.txt in markdown
@Badatos
Upgrade grunt versions
c0d446c
@Badatos
Update ci.yml
59709d7 
Improve Node 14.15 to 18.12
@Badatos
Remove codechecker warnings and errors
17ab479
@Badatos
Remove some phpdoc errors (86 errors before this commit)
f033280
@Badatos
Update ci.yml
bf0c3f0 
Update github actions checkout & setup-node
@Badatos
Correct some phpDocs errors.
16f9724
@Badatos
correct namespace
095066d
@Badatos
remove namespace for behat_filter_oembed
959d896
@Badatos
More phpDoc corrections.
ab3678b
@Badatos
Replace div class=oembed-provider-details by span for w3c compatibili…
315e067 
…ty (no div inside td)
@Badatos
Specify which grunt tasks to run in github ci
d2602ff 
+ add "PHPUNIT_LONGTEST" test before every test calling an external url
@Badatos
add php 8.0 and Moodle 4.0 to github CI
e1c1c2b
@Badatos
Add mysqli to Github CI
05edda5
@Badatos
put NODE_VERSION in env vars for Github CI
036431f
@Badatos
revert node.js to 16.18.1 in github CI
609757f
@Badatos
SET max_input_vars PHP value required for Moodle 400
6a0790b
@Badatos
add some missing namespace declaration
dec18f7
@Badatos
corrections related to namespaces in phpunit tests
12ec34f
@Badatos
Display debugging message when download_file_content can't reach url …
cc7020a 
…(i.e .with SSL errors)
@Badatos
Remove Poll EveryWhere from Unit Tests, as they no more features oembed.
fc0e4eb
@Badatos
Update version.php
e1cb654
@Badatos
Update CHANGES.md
32f9aba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Badatos