Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to bulk sign up for every session in the activity #93

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

cameron1729
Copy link
Contributor

@cameron1729 cameron1729 commented Oct 12, 2022

This patch adds an option to the module create form that changes how students register for sessions. When enabled, instead of one link per session, there is one link per activity, and clicking it signs the student up for every session in the activity.

If a student registers for all sessions using this link, and a teacher later adds a subsequent session, the student will not be automatically registered for that session.

@cameron1729 cameron1729 changed the title WIP: Allow users to bulk sign up for every session in the activity Allow users to bulk sign up for every session in the activity Oct 12, 2022
@dmitriim
Copy link
Member

What about cancelling the sessions (if I signed up for a stream)? should it be cancelled per session or per stream?

@@ -252,6 +252,10 @@
$string['moreinfo'] = 'More info';
$string['multidate'] = '(multi-date)';
$string['multiple'] = 'Multiple';
$string['multiplesignupmethod'] = 'Multiple signup method';
$string['multiplesignupmethod_help'] = 'When set to "single" each session within the activity will have an individual sign up link. When set to "multiple" only one link wil be displayed for the entire activity, any student who registers using this single link will be registered for all sessions within the activity.';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading this I still not really understand the difference between "Per session" vs "Per activity".

Copy link
Contributor Author

@cameron1729 cameron1729 Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added attempted to make this feature clearer. It's a bit of a challenge since the plugin isn't really supposed to work this way and we are kind of shoe-horning functionality in :s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is the same help text for "Signup type" and "Multiple signup method" setting. That's why I was complaining about.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see what happened. Actually they are different, but I made a typo by writing "single" and "multiple" instead of "Per session" and "Per activity". I've fixed that now.

mod_form.php Outdated Show resolved Hide resolved
@cameron1729 cameron1729 force-pushed the signup-per-activity branch 3 times, most recently from 761a647 to 84d7ff9 Compare October 14, 2022 07:51
@danmarsden
Copy link
Member

no objections, haven't reviewed the functionality but once @dmitriim is happy just merge this in! :-)

@dmitriim
Copy link
Member

When I have Signup type = Multiple and Multiple signup method = Per activity, when as a student I go to an activity itself I can see all sessions listed and sign up option against every session. When I book one session it automatically book me in for all sessions without notifying about that.

Should we change inside activity UI as well? Possible options:

  • Have the same UI as from the course page with only one link "Sign-up for stream"
  • After clicking on individual Sign-up link display a notice that you will be signed up for all sessions
  • Replace wording in Options column from Sign-up to Sign-up for stream + maybe show a notification?

@cameron1729
Copy link
Contributor Author

Good catch about that other signup link view @dmitriim - I've pushed a commit implementing option 1

@dmitriim
Copy link
Member

Thanks @cameron1729 it looks good now. I have created new issue #94 that can b e solved separately.
Merging this one in.

@dmitriim dmitriim merged commit a1730a4 into MOODLE_400_STABLE Oct 17, 2022
@dmitriim dmitriim deleted the signup-per-activity branch October 19, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants