-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to bulk sign up for every session in the activity #93
Conversation
8a2e519
to
ae60a29
Compare
What about cancelling the sessions (if I signed up for a stream)? should it be cancelled per session or per stream? |
lang/en/facetoface.php
Outdated
@@ -252,6 +252,10 @@ | |||
$string['moreinfo'] = 'More info'; | |||
$string['multidate'] = '(multi-date)'; | |||
$string['multiple'] = 'Multiple'; | |||
$string['multiplesignupmethod'] = 'Multiple signup method'; | |||
$string['multiplesignupmethod_help'] = 'When set to "single" each session within the activity will have an individual sign up link. When set to "multiple" only one link wil be displayed for the entire activity, any student who registers using this single link will be registered for all sessions within the activity.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading this I still not really understand the difference between "Per session" vs "Per activity".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added attempted to make this feature clearer. It's a bit of a challenge since the plugin isn't really supposed to work this way and we are kind of shoe-horning functionality in :s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what happened. Actually they are different, but I made a typo by writing "single" and "multiple" instead of "Per session" and "Per activity". I've fixed that now.
761a647
to
84d7ff9
Compare
84d7ff9
to
bd52459
Compare
no objections, haven't reviewed the functionality but once @dmitriim is happy just merge this in! :-) |
When I have Signup type = Multiple and Multiple signup method = Per activity, when as a student I go to an activity itself I can see all sessions listed and sign up option against every session. When I book one session it automatically book me in for all sessions without notifying about that. Should we change inside activity UI as well? Possible options:
|
bd52459
to
bdd514a
Compare
Good catch about that other signup link view @dmitriim - I've pushed a commit implementing option 1 |
Thanks @cameron1729 it looks good now. I have created new issue #94 that can b e solved separately. |
This patch adds an option to the module create form that changes how students register for sessions. When enabled, instead of one link per session, there is one link per activity, and clicking it signs the student up for every session in the activity.
If a student registers for all sessions using this link, and a teacher later adds a subsequent session, the student will not be automatically registered for that session.