Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #109: Make replacements idempotent and improve feedback #112

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Issue #109: Make replacements idempotent and improve feedback #112

merged 1 commit into from
Dec 17, 2024

Conversation

petersistrom
Copy link
Contributor

Resolves #109

@petersistrom petersistrom force-pushed the issue-109 branch 2 times, most recently from 048f438 to 885e6aa Compare December 17, 2024 04:20
brendanheywood
brendanheywood reviewed Dec 17, 2024
View reviewed changes
classes/helper.php Outdated Show resolved Hide resolved
brendanheywood
brendanheywood reviewed Dec 17, 2024
View reviewed changes
classes/helper.php Outdated Show resolved Hide resolved
@petersistrom petersistrom force-pushed the issue-109 branch 3 times, most recently from 004b2c7 to 64e3cde Compare December 17, 2024 04:58
@brendanheywood brendanheywood merged commit ca6205d into MOODLE_401_STABLE Dec 17, 2024
27 checks passed
@brendanheywood brendanheywood deleted the issue-109 branch December 17, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanheywood brendanheywood brendanheywood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All replacements should be idempotent and report success if has worked both the first time AND the second time
2 participants
@petersistrom @brendanheywood