Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit test regex #116

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Update unit test regex #116

merged 1 commit into from
Feb 5, 2025

Conversation

bwalkerl
Copy link
Collaborator

@bwalkerl bwalkerl commented Feb 4, 2025

There was 1 error:

1) tool_advancedreplace\helper_test::test_regex_search
Undefined index: page

/var/www/site/admin/tool/advancedreplace/tests/helper_test.php:370
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80
phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:97

The previous regex was not compatible with older versions of mysql (like 5.7), which was causing this error in a few environments. There should be no harm in changing the regex to a simplified version.

@bwalkerl bwalkerl merged commit f0ecdf6 into MOODLE_401_STABLE Feb 5, 2025
46 checks passed
@bwalkerl bwalkerl deleted the unit-test-regex branch February 5, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant