Totara 19 fixes #64
Merged
Totara 19 fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmarsden
reviewed
Mar 4, 2025
| @@ -208,7 +208,7 @@ private function generate_store_instance_config(array $stores): array { | |||
| foreach ($stores as $name => $store) { | |||
|
|
|||
| // First check that all the required fields are present in the store. | |||
| if (!(array_key_exists('type', $store) || | |||
| if (!(array_key_exists('type', $store) && | |||
There was a problem hiding this comment.
This line doesn't feel like a Totara specific change to me? - should it land in the main branch and be backported to the t19 branch?
There was a problem hiding this comment.
This entire MR should probably go in the main branch.
I suspect this issue, and that of the mismatched fields, haven't been detected because the test function's processing stops once the first exception is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtest fixes for compatibility with T19 and phpunit 10.5