Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numpy 2.0 in the testing suite. #1235

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Mar 4, 2025

More support for numpy 2.0 in the testing suite.

  • I need to change the representation in some warning functions because of this:

https://numpy.org/devdocs/release/2.0.0-notes.html#representation-of-numpy-scalars-changed

  • And also:

Use of keyword arguments x and y with functions assert_array_equal and assert_array_almost_equal has been deprecated. Pass the first two arguments as positional arguments instead.

https://numpy.org/devdocs/release/2.0.0-notes.html#deprecations

@bendichter bendichter enabled auto-merge (squash) March 5, 2025 02:45
@bendichter bendichter merged commit 0381741 into main Mar 5, 2025
40 checks passed
@bendichter bendichter deleted the more_support_numpy_3 branch March 5, 2025 04:18
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base (fe9badc) to head (d3bc495).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/neuroconv/tools/testing/data_interface_mixins.py 83.33% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   90.39%   90.40%           
=======================================
  Files         133      133           
  Lines        8508     8511    +3     
=======================================
+ Hits         7691     7694    +3     
  Misses        817      817           
Flag Coverage Δ
unittests 90.40% <85.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/neuroconv/tools/spikeinterface/spikeinterface.py 95.53% <100.00%> (+0.02%) ⬆️
...c/neuroconv/tools/testing/data_interface_mixins.py 95.67% <83.33%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants