Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small improvements to BrukerTiffMultiPlaneImagingExtractor #268

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

h-mayorquin
Copy link
Collaborator

  1. Avoid calculating calling determine_imaging_is_volumetric which parses the whole xml file twice. The code to get the streams already calculates this and if returns sucesfully the streams have plane_streams:

streams["plane_streams"] = dict()
if not _determine_imaging_is_volumetric(folder_path=folder_path):
return streams

  1. When stream_name is not passed and there are multiple channels we can make the life of the user easier by already displaying the options which we have already available.

@h-mayorquin h-mayorquin self-assigned this Dec 5, 2023
@h-mayorquin h-mayorquin marked this pull request as ready for review December 5, 2023 12:23
@CodyCBakerPhD
Copy link
Member

Leaving this one to @alessandratrapani as well

Copy link
Collaborator

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better!

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #268 (b17b2b1) into main (518baca) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   79.13%   79.17%   +0.03%     
==========================================
  Files          39       39              
  Lines        3053     3054       +1     
==========================================
+ Hits         2416     2418       +2     
+ Misses        637      636       -1     
Flag Coverage Δ
unittests 79.17% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...iffimagingextractors/brukertiffimagingextractor.py 96.10% <100.00%> (+0.40%) ⬆️

@h-mayorquin h-mayorquin merged commit 88004d1 into main Dec 19, 2023
14 checks passed
@h-mayorquin h-mayorquin deleted the small_improvement_to_bruker branch December 19, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants