Update from Working-model: bc3df0f #135
Conversation
stephanbcbauer
requested review from
werner-roman,
Grand-Thibault,
jSchuetz88 and
ther3sa
There was a problem hiding this comment.
Not readable in dark mode - needs background
| @@ -1,16 +1,15 @@ | |||
| --- | |||
| sidebar_position: 5 | |||
| title: Catena-X office | |||
There was a problem hiding this comment.
I think we should keep the h1 heading - as this is used by all the other documents as well - at leas I don't see a benefit in using title?
There was a problem hiding this comment.
we are usually using title instead of h1
There was a problem hiding this comment.
Is there a benefit? otherwise i think we should keep it consistent across all documents?
| @@ -33,7 +33,7 @@ There are two main organizations in GitHub: | |||
|
|
|||
| :::note | |||
|
|
|||
| - for the open-source part (reference implementations and Kits) GitHub is mandatory. Its used for planning, issue tracking, discussions, development, reviews and release etc. | |||
| - for the open-source part (reference implementations and KITs) GitHub is mandatory. Its used for planning, issue tracking, discussions, development, reviews and release etc. | |||
| - for the standardization part, GitHub is also set as mandatory | |||
| - for Committee work and Expert Groups the Association provides private repositories within the *catenax-eV* GitHub organization | |||
There was a problem hiding this comment.
Not readable in dark mode - needs background
There was a problem hiding this comment.
Not readable in dark mode - needs background
|
Why is this PR empty? is this still up-to-date? Can we close this PR? |
|
since this was never merged, should we delete this PR and create a new one? -> i think the comments by @werner-roman are still valid ;) @Grand-Thibault |
|
@Grand-Thibault would like to delete this PR, since the changes are old, but I still don't want to lose the comments by @werner-roman. @Grand-Thibault, can you please fix it in the working-model? |
This PR updates the branch with the latest changes from Working-model. Commit ID: bc3df0f
These are the last changes from working model. Would like to merge them, before we execute the versioning plug-in.
@ther3sa and @werner-roman you are the only once who are left for review :)