Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change recommended default config, so that window names are automatically set (#53) #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jnussbaum
Copy link

The docs state that if the recommended default config is applied, tmux windows are automatically renamed according to the CWD. But as discussed in #53, this is currently not the case. This PR updates the recommended default config, to align it with what the docs say.

@kjnsn
Copy link
Collaborator

kjnsn commented Jan 31, 2025

Can you point to where in the docs it mentions that the window names match the current directory?

@@ -160,6 +160,13 @@ set -ag status-right "#{E:@catppuccin_status_session}"
set -ag status-right "#{E:@catppuccin_status_uptime}"
set -agF status-right "#{E:@catppuccin_status_battery}"

# automatically set CWD as window name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is #W the current directory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this from #53 (comment). But I'm not knowledgeable enough to say what it means.

@@ -160,6 +160,13 @@ set -ag status-right "#{E:@catppuccin_status_session}"
set -ag status-right "#{E:@catppuccin_status_uptime}"
set -agF status-right "#{E:@catppuccin_status_battery}"

# automatically set CWD as window name
set -g @catppuccin_window_default_text "#W"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option no longer exists

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, took it from #53 (comment).

set -g @catppuccin_window_default_text "#W"
set -g @catppuccin_window_current_text "#W"
set -g @catppuccin_window_text "#W"
set-option -g automatic-rename on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why automatic rename if #W is used? It updates automatically anyway

And please be consistent with set and set-option. They are aliases and set is used everywhere else

set -g @catppuccin_window_current_text "#W"
set -g @catppuccin_window_text "#W"
set-option -g automatic-rename on
set-option -g automatic-rename-format '#I #{b:pane_current_path}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

@kjnsn kjnsn changed the title docs: fix recommended default config, so that window names are automatically set (#53) docs: change recommended default config, so that window names are automatically set (#53) Jan 31, 2025
@jnussbaum
Copy link
Author

Can you point to where in the docs it mentions that the window names match the current directory?

There are 2 sources that imply that this would be the case:

But you're right that it is not stated explicitly in your docs. So perhaps this PR is obsolete.

@kjnsn
Copy link
Collaborator

kjnsn commented Feb 19, 2025

But you're right that it is not stated explicitly in your docs. So perhaps this PR is obsolete.

I wouldn't say this PR is obsolete, I'm keen for the mechanics & configuration surrounding window names to be made clearer and more obvious.

I'd recommend taking a look at the tmux man page and wiki, and potentially the tmux issue list as well. And then coming back to address the feedback on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants