Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add URLs to DESCRIPTION #4

Merged
merged 1 commit into from
Dec 10, 2024
Merged

add URLs to DESCRIPTION #4

merged 1 commit into from
Dec 10, 2024

Conversation

jameslamb
Copy link
Contributor

@jameslamb jameslamb commented Dec 8, 2024

👋🏻 Hi, I'm one of the maintainers of {lightgbm} (https://github.com/microsoft/LightGBM).

I'm working on adding some tests there that check that changes to {lightgbm} don't break any libraries that depend on it (microsoft/LightGBM#6734). I might want to propose some changes to {misspi} as a result of looking into test failures from that effort. I did not realize that this project was being developed on GitHub, because there is no mention of this repo in the docs at https://cran.r-project.org/web/packages/misspi/index.html.

This proposes adding links to DESCRIPTION, which will show up on the project's CRAN homepage. Example from https://cran.r-project.org/web/packages/lightgbm/index.html:

Screenshot 2024-12-07 at 11 48 54 PM

That's a result of similar DESCRIPTION content in {lightgbm}: https://github.com/microsoft/LightGBM/blob/d4d6c87db02a146ac6dc04b00f538e02a3b22250/R-package/DESCRIPTION#L42-L43

Thanks for your time and consideration, and for using LightGBM!

@catstats catstats merged commit 89d49c5 into catstats:master Dec 10, 2024
0 of 5 checks passed
@catstats
Copy link
Owner

Thank you so much for your suggestion and for taking the time to look into {misspi}. I’ve merged the pull request and will update the R CRAN version shortly to reflect these changes. I also want to thank you for maintaining such an excellent package in {lightgbm}—it’s a pleasure to use and integrate with!

@jameslamb jameslamb deleted the docs/urls branch December 10, 2024 06:04
@jameslamb
Copy link
Contributor Author

Thanks! Please open an issue over at https://github.com/microsoft/LightGBM/issues if you have questions, feature requests, or bug reports 👋🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants