Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋🏻 Hi, I'm one of the maintainers of
{lightgbm}
(https://github.com/microsoft/LightGBM).I'm working on adding some tests there that check that changes to
{lightgbm}
don't break any libraries that depend on it (microsoft/LightGBM#6734). I might want to propose some changes to{misspi}
as a result of looking into test failures from that effort. I did not realize that this project was being developed on GitHub, because there is no mention of this repo in the docs at https://cran.r-project.org/web/packages/misspi/index.html.This proposes adding links to
DESCRIPTION
, which will show up on the project's CRAN homepage. Example from https://cran.r-project.org/web/packages/lightgbm/index.html:That's a result of similar
DESCRIPTION
content in{lightgbm}
: https://github.com/microsoft/LightGBM/blob/d4d6c87db02a146ac6dc04b00f538e02a3b22250/R-package/DESCRIPTION#L42-L43Thanks for your time and consideration, and for using LightGBM!