Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtk_statevars and vtk in all json to fix nightly error #17

Closed
wants to merge 2 commits into from

Conversation

bodhinandach
Copy link
Contributor

Describe the PR
Since we are removing try and catch in PR cb-geo/mpm#683 and cb-geo/mpm#684, "vtk" and "vtk_statevars" keywords are necessary in the json file. I am adding those to the benchmark .json.

Copy link
Contributor

@kks32 kks32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding empty vtk and vtk_statevars is a good fix. Could we discuss how we can fix this in the mpm repo?

@bodhinandach
Copy link
Contributor Author

Sure. Sorry, I also didnt notice this as my test has those two keywords.

@bodhinandach bodhinandach deleted the hotfix/missing_vtk_keys branch August 9, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants