Fix incorrect param name #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 187 187
=========================================
Hits 187 187 ☔ View full report in Codecov by Sentry. |
wagnerlmichael
commented
Mar 20, 2024
| @@ -23,7 +23,7 @@ In general, there are four important statistics produced in sales ratio studies, | |||
| | **COD** | 5 - 15 | How often properties with the *same* sale price receive the same predicted market value. Lower CODs indicate more fairness between similarly priced properties. | | |||
| | **PRD** | .98 - 1.03 | How often properties with *different* sale prices receive the proportionately different predicted market values. Lower PRDs indicate more fairness between low and high-priced properties. | | |||
| | **PRB** | -.05 - .05 | PRB is a different approach to measuring fairness across homes with different sale prices. | | |||
| | **Median Ratio** | .095 - 1.05 | The median ratio measures whether the most common ratios accurately reflect sale prices. | | |||
| | **Median Ratio** | .95 - 1.05 | The median ratio measures whether the most common ratios accurately reflect sale prices. | | |||
There was a problem hiding this comment.
This looks like it was a typo.
dfsnow
approved these changes
Mar 20, 2024
| @@ -23,7 +23,7 @@ In general, there are four important statistics produced in sales ratio studies, | |||
| | **COD** | 5 - 15 | How often properties with the *same* sale price receive the same predicted market value. Lower CODs indicate more fairness between similarly priced properties. | | |||
| | **PRD** | .98 - 1.03 | How often properties with *different* sale prices receive the proportionately different predicted market values. Lower PRDs indicate more fairness between low and high-priced properties. | | |||
| | **PRB** | -.05 - .05 | PRB is a different approach to measuring fairness across homes with different sale prices. | | |||
| | **Median Ratio** | .095 - 1.05 | The median ratio measures whether the most common ratios accurately reflect sale prices. | | |||
| | **Median Ratio** | .95 - 1.05 | The median ratio measures whether the most common ratios accurately reflect sale prices. | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the problem here is that we were referencing a parameter that doesn't exist. It works with
tax_year.yeardoesn't seem to exist in the json structure.Closes #7